[M] Change in coreboot[master]: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Kapil Porwal.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75755?usp=email )

Change subject: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot
......................................................................

Patch Set 13:

(9 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/75755/comment/69759280_a68594f4 :
PS13, Line 136: 
              : struct cse_fw_state {
              : 	bool is_cse_fw_updated;
              : 	bool is_cold_boot;
              : };
thoughts ?

static struct cse_fw_state {
    bool is_cse_fw_updated;
    bool is_cold_boot;
} fw_state;

https://review.coreboot.org/c/coreboot/+/75755/comment/57fbf638_9e224264 :
PS13, Line 1204: 	size_t size = sizeof(struct fw_version);
               : 	fw_state.is_cse_fw_updated = fw_state.is_cold_boot = false;
can you please lines from here to 1201 (after prev_cse_fw_version )?

https://review.coreboot.org/c/coreboot/+/75755/comment/0591b9ec_1795c1c8 :
PS13, Line 1211: cse
please use `CSE` as in caps because its a acronym

https://review.coreboot.org/c/coreboot/+/75755/comment/2f19eadc_27614b95 :
PS13, Line 1225: fw
FW

https://review.coreboot.org/c/coreboot/+/75755/comment/bd7f1c17_aa31de8c :
PS13, Line 1225: rw
RW

https://review.coreboot.org/c/coreboot/+/75755/comment/00726a89_c84b2aa7 :
PS13, Line 1312: ish
ISH

https://review.coreboot.org/c/coreboot/+/75755/comment/9e657c77_d25fbd05 :
PS13, Line 1316: &(resp.manifest_data.version)
get the version and store into a local variable so you can use it below

https://review.coreboot.org/c/coreboot/+/75755/comment/b58fb160_5db65101 :
PS13, Line 1318: 			memcpy(&(version->ish_partition_info.cur_ish_fw_version),
               : 				&(resp.manifest_data.version), size);
don't need, please follow below code

https://review.coreboot.org/c/coreboot/+/75755/comment/2820ed44_29fe8b0f :
PS13, Line 1328: 		memcpy(&(version->ish_partition_info.cur_ish_fw_version),
               : 			&cmos_ish_version, size);
make this code outside if/else block?
    /* Write ISH FW version to CBMEM if previous stored version is not valid */
    if (fw_state.is_cold_boot || fw_state.is_cse_fw_updated)
           memcpy(&(version->ish_partition_info.cur_ish_fw_version),
    		&cmos_ish_version, size);