Attention is currently required from: Julius Werner, Kapil Porwal, Paul Menzel, Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76371?usp=email )
Change subject: arch/x86: Implement config to Vendor Specific Data during PRERAM
......................................................................
Patch Set 9:
(2 comments)
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/76371/comment/d9c74015_578f46e0 :
PS8, Line 138: PRERAM_CBMEM_SIZE
Why do we need such a high default value @Dinesh ? shouldn't 8bytes default in enough ?
Default size modified to 4 bytes.
https://review.coreboot.org/c/coreboot/+/76371/comment/b31f3f6e_baf22da7 :
PS8, Line 143: Default reserved memory for preram CBMEM entries
That’s 128 bytes?
Default size modified to 4 bytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76371?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia40f6a33cf2fd0198042c4e6733eea7debb78e8d
Gerrit-Change-Number: 76371
Gerrit-PatchSet: 9
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 02 Aug 2023 15:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment