[S] Change in coreboot[master]: soc/intel/meteorlake: Adjust discovery table offset based on CPUID

[Jakub Czapiga (Code Review)]

Attention is currently required from: Kapil Porwal, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, Tracy Wu.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76400?usp=email )

Change subject: soc/intel/meteorlake: Adjust discovery table offset based on CPUID
......................................................................

Patch Set 11:

(3 comments)

File src/soc/intel/meteorlake/crashlog.c:

https://review.coreboot.org/c/coreboot/+/76400/comment/4ce5ca96_1f58bc67 :
PS11, Line 358: u32 bar_addr = 0, disc_tab_addr = 0, disc_tab_offset = 0;
code-style: AFAIK we are using C11 (`-std=gnu11`), so variable declarations are not required to be at the beginning of the function. Can we get rid of unnecessary lines like this one and declare&define variables in line they are first assigned (if feasible)?

https://review.coreboot.org/c/coreboot/+/76400/comment/a970fba6_096d0ddd :
PS11, Line 367: disc_tab_offset <<= 3;
Is there a risk of overflow in this operation?

https://review.coreboot.org/c/coreboot/+/76400/comment/4c3b24a4_1986e789 :
PS11, Line 374: cpu_cl_disc_tab.header.data = ((u64)read32((u32 *)disc_tab_addr) +
              : 					((u64)read32((u32 *)(disc_tab_addr + 4)) << 32));
              : 
Shouldn't it be binary-OR instead of addition? (Just asking for clarification :) )