Attention is currently required from: Paul Menzel, Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55138 )
Change subject: mb/emulation/qemu-q35: Fix running qemu-i386 with SMM
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/emulation/qemu-q35/cpu.c:
https://review.coreboot.org/c/coreboot/+/55138/comment/04b329e4_ea6ea6ce
PS4, Line 52: case 0x00020000:
My comment was sort of bad; I did not necessarily mean adding new revision here. […]
qemu/target/i386/tcg/sysemu/smm_helper.c
/* SMM support */
#ifdef TARGET_X86_64
#define SMM_REVISION_ID 0x00020064
#else
#define SMM_REVISION_ID 0x00020000
#endif
So currently, even if qemu command line -cpu parameter is used, those are the possible revision numbers we could see here.
ASEG works with PARALLEL_MP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6994c8d6e10fd06655129dbd801f1f9d5fd639f
Gerrit-Change-Number: 55138
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 11 Nov 2022 17:44:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment