Change in coreboot[master]: device/mmio.h: Move readXp/writeXp helpers to device/mmio.h - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: Lance Zhao, Arthur Heymans, Tim Wawrzynczak, Julius Werner, Angel Pons, Patrick Rudolph, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62561 )
Change subject: device/mmio.h: Move readXp/writeXp helpers to device/mmio.h
......................................................................
Patch Set 4:
(1 comment)
File src/arch/arm/include/armv4/arch/mmio.h:
https://review.coreboot.org/c/coreboot/+/62561/comment/97eca4dc_60fd27c3 
PS4, Line 27: static inline uint64_t read64(const void *addr)
...
this architecture doesn't support 64bit data stores
Could we call die("Not supported") here?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic13a94d91affb7cf65a2f22f08ea39ed671bc8e8
Gerrit-Change-Number: 62561
Gerrit-PatchSet: 4
Gerrit-Owner: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 02:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment