Attention is currently required from: Jg Daolongzhu, Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58053 )
Change subject: soc/mediatek: Fix I2C failures by adjusting AC timing and bus speed
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/58053/comment/559084ce_57b6c188
PS1, Line 94: read32(®s->ltiming),
: read32(®s->clock_div
mt8173 struct doesn't have these fields.
Done
File src/soc/mediatek/mt8195/i2c.c:
https://review.coreboot.org/c/coreboot/+/58053/comment/ecf2980b_26c65eb7
PS1, Line 10:
No blank line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58053
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id25b7bb3a76908a7943b940eb5bee799e80626a0
Gerrit-Change-Number: 58053
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 06:48:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment