Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Felix Held, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80378?usp=email )
Change subject: mainboard/qemu-riscv: Add PCI support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/emulation/qemu-riscv/mainboard.c:
https://review.coreboot.org/c/coreboot/+/80378/comment/3cfd7ddc_e8eb7235?usp... :
PS2, Line 42: res->base = ALIGN_UP((uintptr_t)_dram + (uintptr_t)cbmem_top(),
`cbmem_top()` via probing RAM is limited to detecting up to 16 GiB after CB:36486 even if there's mo […]
probing is not an issue anymore.
But you should probably rebase once more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80378?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie57b35620af82c681d1f0d78fa8e514e4df0d2ac
Gerrit-Change-Number: 80378
Gerrit-PatchSet: 2
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alper Nebi Yasak
alpernebiyasak@gmail.com