Attention is currently required from: Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Sean Rhodes, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83877?usp=email )
Change subject: soc/intel/alderlake: Correctly set SATA Device Sleep pins
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83877/comment/75ed3549_9f4b52b6?usp... :
PS1, Line 859: 0x59673e0c
The hardcoded numbers lacks sufficient explanation. It would be beneficial to include references to relevant documentation in the description. Additionally, if feasible, consider replacing the direct use of numbers with const macros.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83877?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf6135fd58142636c3fc2210b3dc0e23870aeb09
Gerrit-Change-Number: 83877
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 12 Aug 2024 13:58:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No