Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )
Change subject: mb/google/rex/variants/ovis: Add USB and TCSS configuration
......................................................................
Patch Set 7:
(4 comments)
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75578/comment/213280fc_4296f70f :
PS7, Line 138: CENTER
we already have `front, center` for Type-C 0
ideally Type-A1 can be either `top` or `bottom`
https://review.coreboot.org/c/coreboot/+/75578/comment/31585ca5_ce9b796f :
PS7, Line 145: 4, 1
shouldn't this be 3, 3?
https://review.coreboot.org/c/coreboot/+/75578/comment/d29c414c_68612a2f :
PS7, Line 152: (4, 2)
3, 4 ?
https://review.coreboot.org/c/coreboot/+/75578/comment/5637ab60_edecb110 :
PS7, Line 166: CENTER
either top or bottom may be ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75578?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc81f12ec6cc4af37bcc1fcf3164cbfa5612a443
Gerrit-Change-Number: 75578
Gerrit-PatchSet: 7
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 12:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment