[S] Change in coreboot[main]: soc/intel/cml, pci_ids: Fix IDs for UHD 610/630 S/H - coreboot-gerrit

9 Aug 2024


      Attention is currently required from: Jérémy Compostella, Maxim, Subrata Banik.
Felix Singer has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83708?usp=email )
Change subject: soc/intel/cml, pci_ids: Fix IDs for UHD 610/630 S/H
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83708/comment/3a3d1dd9_ce21fb98?usp... :
PS8, Line 41: Fix the corresponding IDs and remove duplicate entries.
It's not clear to me which of them are duplicates and why they are duplicates. Please add more explanation on that. Also, move this to the top. Otherwise the links are a bit confusing.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83708?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab0a03388af3f6fd5d78a597580037889e8ef2
Gerrit-Change-Number: 83708
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Shuo Liu shuo.liu@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Maxim max.senia.poliak@gmail.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Comment-Date: Fri, 09 Aug 2024 06:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No