Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59308 )
Change subject: amdfwtool: Use address mode ......................................................................
Patch Set 1:
(5 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133307): https://review.coreboot.org/c/coreboot/+/59308/comment/73e14183_f20bb2f1 PS1, Line 355: ((mode) == 2 ? (offset) - ctx.current_table : (offset)) )) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133307): https://review.coreboot.org/c/coreboot/+/59308/comment/4c9c32bf_a3bbfc57 PS1, Line 689: pspdir->entries[count].address_mode = pspdir->header.additional_info_fields.address_mode; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133307): https://review.coreboot.org/c/coreboot/+/59308/comment/2b878418_326f99de PS1, Line 741: pspdir->entries[count].address_mode = pspdir->header.additional_info_fields.address_mode; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133307): https://review.coreboot.org/c/coreboot/+/59308/comment/343e5d3c_6d4d395b PS1, Line 947: biosdir->entries[count].address_mode = biosdir->header.additional_info_fields.address_mode; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133307): https://review.coreboot.org/c/coreboot/+/59308/comment/227c58ae_b194a271 PS1, Line 1004: biosdir->entries[count].address_mode = biosdir->header.additional_info_fields.address_mode; line over 96 characters
-
build bot (Jenkins) (Code Review)