Attention is currently required from: Knox Chiou, zanxi chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64790 )
Change subject: mb/google/corsola: Enable ps8640 for steelix ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/64790/comment/284346ad_802a901a PS3, Line 125: CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1 You'll also need to change this to
CONFIG(DRIVER_ANALOGIX_ANX7625) + CONFIG(DRIVER_PARADE_PS8640) == 1
or ensure the same thing using `choice` in Kconfig.
https://review.coreboot.org/c/coreboot/+/64790/comment/76473abb_fb327b06 PS3, Line 136: else if (CONFIG(BOARD_GOOGLE_KRABBY) || CONFIG(BOARD_GOOGLE_STEELIX)) If this starts getting complicated, we should make it a Kconfig option. In corsola/Kconfig, we can select only one of DRIVER_ANALOGIX_ANX7625 and DRIVER_PARADE_PS8640 (not both). Then here use them to determine the bridge to initialize.