Attention is currently required from: Tarun Tuli, Subrata Banik, John Zhao.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74221 )
Change subject: soc/intel/meteorlake: Add VPU into the DMAR SATC table
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/74221/comment/40e14119_9b0bdf13
PS1, Line 273: acpi_create_dmar_ds_pci
You are not checking if the device is enabled or not. Is this ok?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d4af7c9844e33483a1e616eaee061a90d0be6fc
Gerrit-Change-Number: 74221
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 05:28:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment