Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37600 )
Change subject: mb/lenovo/t431s/devicetree: Rebalance against t430s one ......................................................................
mb/lenovo/t431s/devicetree: Rebalance against t430s one
Change-Id: Iec40dd20c87b97dbd81ba3c63486cb5e66d99dc6 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb 1 file changed, 2 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/37600/1
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb index e3388de..ae95e6c 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb +++ b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb @@ -15,17 +15,14 @@ device domain 0 on subsystemid 0x17aa 0x2208 inherit
- device pci 00.0 on end # host bridge device pci 01.0 off end # PCIe Bridge for discrete graphics - device pci 02.0 on end # Integrated Graphics Controller + chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH # Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) & 4 (dock) register "sata_port_map" = "0x13" # T431s has no Express Card slot. register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" - device pci 14.0 on end # USB 3.0 Controller - device pci 1a.0 on end # USB Enhanced Host Controller #2 - device pci 1b.0 on end # High Definition Audio Controller + device pci 1c.0 on # PCIe Port #1 chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x87" @@ -33,10 +30,7 @@ device pci 00.0 on end # Ricoh SD card reader end end - device pci 1c.1 on end # PCIe Port #2 Integrated Wireless LAN device pci 1c.2 off end # PCIe Port #3 - device pci 1d.0 on end # USB Enhanced Host Controller #1 - device pci 1e.0 off end # PCI bridge device pci 1f.0 on chip ec/lenovo/h8 register "config0" = "0xa6" @@ -47,8 +41,6 @@ register "has_bdc_detection" = "0" end end # LPC Controller - device pci 1f.2 on end # 6 port SATA AHCI Controller - device pci 1f.3 on end # SMBus Controller device pci 1f.6 off end # Thermal end end
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37600 )
Change subject: mb/lenovo/t431s/devicetree: Rebalance against t430s one ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37600/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37600/4//COMMIT_MSG@7 PS4, Line 7: mb/lenovo/t431s/devicetree: Rebalance against t430s one Maybe reword this a little bit:
mb/lenovo/t431s: Align overridetree with t430s
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37600 )
Change subject: mb/lenovo/t431s/devicetree: Rebalance against t430s one ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37600/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37600/4//COMMIT_MSG@7 PS4, Line 7: mb/lenovo/t431s/devicetree: Rebalance against t430s one
Maybe reword this a little bit: […]
Not wrong and it seems no update will happen...
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37600 )
Change subject: mb/lenovo/t431s/devicetree: Rebalance against t430s one ......................................................................
mb/lenovo/t431s/devicetree: Rebalance against t430s one
Change-Id: Iec40dd20c87b97dbd81ba3c63486cb5e66d99dc6 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37600 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb 1 file changed, 2 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb index e3388de..ae95e6c 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb +++ b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb @@ -15,17 +15,14 @@ device domain 0 on subsystemid 0x17aa 0x2208 inherit
- device pci 00.0 on end # host bridge device pci 01.0 off end # PCIe Bridge for discrete graphics - device pci 02.0 on end # Integrated Graphics Controller + chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH # Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) & 4 (dock) register "sata_port_map" = "0x13" # T431s has no Express Card slot. register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" - device pci 14.0 on end # USB 3.0 Controller - device pci 1a.0 on end # USB Enhanced Host Controller #2 - device pci 1b.0 on end # High Definition Audio Controller + device pci 1c.0 on # PCIe Port #1 chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x87" @@ -33,10 +30,7 @@ device pci 00.0 on end # Ricoh SD card reader end end - device pci 1c.1 on end # PCIe Port #2 Integrated Wireless LAN device pci 1c.2 off end # PCIe Port #3 - device pci 1d.0 on end # USB Enhanced Host Controller #1 - device pci 1e.0 off end # PCI bridge device pci 1f.0 on chip ec/lenovo/h8 register "config0" = "0xa6" @@ -47,8 +41,6 @@ register "has_bdc_detection" = "0" end end # LPC Controller - device pci 1f.2 on end # 6 port SATA AHCI Controller - device pci 1f.3 on end # SMBus Controller device pci 1f.6 off end # Thermal end end
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Peter Lemenkov (Code Review)