Change in ...coreboot[master]: [WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp
Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33746
Change subject: [WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
[WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp
Change-Id: I0778ee21cb4f66b8ec884b77788c05a73c609be6 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33746/1
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index dac3522..8e362c1 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -62,6 +62,7 @@ select CPU_INTEL_COMMON select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select FSP_M_XIP + select FSP_USES_CB_STACK select GENERIC_GPIO_LIB select HAVE_FSP_GOP select INTEL_DESCRIPTOR_MODE_CAPABLE @@ -120,6 +121,7 @@
config DCACHE_BSP_STACK_SIZE hex + default 0x20000 if FSP_USES_CB_STACK default 0x4000 help The amount of anticipated stack usage in CAR by bootblock and
Bora Guvendik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: [WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Abandoned
34130 is same as this. Abandoning this one.
Bora Guvendik has restored this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: [WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Restored
Hello Subrata Banik, Aamir Bohra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33746
to look at the new patch set (#2).
Change subject: [WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
[WIP]soc/intel/cannonlake: Allow coreboot to reserve stack for fsp
Change-Id: I0778ee21cb4f66b8ec884b77788c05a73c609be6 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33746/2
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33746
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
soc/intel/cannonlake: Allow coreboot to reserve stack for fsp
FSP BIOS 212 / 07.00.6C.40 for CNL/WHL supports FSP to use coreboot stack. This change selects common stack config, that enables coreboot to support share stack with FSP.
TEST=Boot to OS on WHL platform
Change-Id: I0778ee21cb4f66b8ec884b77788c05a73c609be6 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33746/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Patch Set 3: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
soc/intel/cannonlake: Allow coreboot to reserve stack for fsp
FSP BIOS 212 / 07.00.6C.40 for CNL/WHL supports FSP to use coreboot stack. This change selects common stack config, that enables coreboot to support share stack with FSP.
TEST=Boot to OS on WHL platform
Change-Id: I0778ee21cb4f66b8ec884b77788c05a73c609be6 Signed-off-by: Bora Guvendik bora.guvendik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33746 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Aamir Bohra: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index fc3f2ac..c1fda95 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -29,6 +29,7 @@ config SOC_INTEL_WHISKEYLAKE bool select SOC_INTEL_CANNONLAKE_BASE + select FSP_USES_CB_STACK help Intel Whiskeylake support
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Patch Set 4:
I am having serious issues with this on my Whiskey Lake system (System76 Galago Pro galp3-c). This causes FspMemoryInit to fail with INVALID_PARAMETER.
Please let me know if you have any questions
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Patch Set 4:
Patch Set 4:
I am having serious issues with this on my Whiskey Lake system (System76 Galago Pro galp3-c). This causes FspMemoryInit to fail with INVALID_PARAMETER.
Please let me know if you have any questions
What FSP version are you using?
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
I am having serious issues with this on my Whiskey Lake system (System76 Galago Pro galp3-c). This causes FspMemoryInit to fail with INVALID_PARAMETER.
Please let me know if you have any questions
What FSP version are you using?
The latest version, Coffee Lake 7.0.64.40
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp ......................................................................
Patch Set 4:
Thanks for catching this, FSP binaries are now updated in Intel/FSP git
-
Aamir Bohra (Code Review) -
Bora Guvendik (Code Review)
-
Jeremy Soller (Code Review)
-
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)