Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65417?usp=email )
Change subject: cbfstool: Correctly interpret uninitialized MMAP window ranges
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Was the unresolved comment solved already?
I don't have any memory of this patch. Arthur has since changed a bunch of how this works in CB:68160. I believe(?) that with his patch it shouldn't be possible to have a mapping window of size 0 anymore (although I'm not quite sure how it was previously possible to begin with). I think this patch is probably still valid as a sanity check but I don't think it should be possible to hit that case anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65417?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e2afde0373aafebc95f9b717ea7e2d2c55bc6d5
Gerrit-Change-Number: 65417
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 21:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment