Attention is currently required from: Jakub Czapiga.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69208 )
Change subject: vboot: Introduce handy vboot reboot functions
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
I like the refactor, nice.
File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/b8ac6556_da425fbf
PS1, Line 14: if (!verification_should_run() && !(ENV_ROMSTAGE && CONFIG(VBOOT_EARLY_EC_SYNC))
Is this block belong to the next patch?
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/0ee43278_0cb7afae
PS1, Line 354: vboot_save_data(ctx);
Any side effect if we save twice? Should be fine I think.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie29410e8985e7cf19bd8d4cccc393b050ca1f1c5
Gerrit-Change-Number: 69208
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Comment-Date: Sat, 05 Nov 2022 12:11:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment