Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83908?usp=email )
Change subject: soc/intel/xeon_sp/uncore_acpi: use is_dev_on_domain0 where possible ......................................................................
soc/intel/xeon_sp/uncore_acpi: use is_dev_on_domain0 where possible
Replace 'is_domain0(dev_get_domain(dev))' with 'is_dev_on_domain0(dev)' which is a helper function that does exactly the same, but slightly simplifies the call.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I8b0c52a9176288039e6414a09c3fe0662db79e4b Reviewed-on: https://review.coreboot.org/c/coreboot/+/83908 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Shuo Liu shuo.liu@intel.com Reviewed-by: Elyes Haouas ehaouas@noos.fr --- M src/soc/intel/xeon_sp/uncore_acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Shuo Liu: Looks good to me, approved build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index 0b2b9f4..baffdd0 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -532,7 +532,7 @@ struct device *dev = NULL; struct device *iommu0 = NULL; while ((dev = dev_find_device(PCI_VID_INTEL, MMAP_VTD_CFG_REG_DEVID, dev))) { - if (is_domain0(dev_get_domain(dev))) { + if (is_dev_on_domain0(dev)) { iommu0 = dev; continue; }