[S] Change in coreboot[master]: soc/amd/cezanne/reset: deduplicate code - coreboot-gerrit

1 Feb 2023


      Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72690 )
Change subject: soc/amd/cezanne/reset: deduplicate code
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/cezanne/reset.c:
https://review.coreboot.org/c/coreboot/+/72690/comment/9975be89_2814322d 
PS1, Line 21: do_cold_reset();
is it worth adding a printk here to alert that a warm reset was requested but a cold reset will be performed?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3fe010a2b361ae9a1befeb4f07b12a80d978460
Gerrit-Change-Number: 72690
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 01 Feb 2023 17:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment