Change in coreboot[master]: security/vboot/sync_ec: Add timestamps

List overview All Threads
Download

newer

older

Change in coreboot[master]: Update...

Change in coreboot[master]:...

Tim Wawrzynczak (Code Review)

21 Oct 2019 21 Oct '19

12:37 p.m.

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/sync_ec.c 2 files changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/1

diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h index 7b1a730..b6c7c4f 100644 --- a/src/commonlib/include/commonlib/timestamp_serialized.h +++ b/src/commonlib/include/commonlib/timestamp_serialized.h @@ -82,6 +82,8 @@ TS_START_COPYVPD = 550, TS_END_COPYVPD_RO = 551, TS_END_COPYVPD_RW = 552, + TS_START_EC_SYNC = 553, + TS_END_EC_SYNC = 554,

/* 900-920 reserved for vendorcode extensions (900-940: AMD AGESA) */ TS_AGESA_INIT_RESET_START = 900, @@ -202,6 +204,9 @@ { TS_END_COPYVPD_RO, "finished loading Chrome OS VPD (RO)" }, { TS_END_COPYVPD_RW, "finished loading Chrome OS VPD (RW)" },

+ { TS_START_EC_SYNC, "starting EC software sync" }, + { TS_END_EC_SYNC, "finished EC software sync" }, + { TS_DC_START, "depthcharge start" }, { TS_RO_PARAMS_INIT, "RO parameter init" }, { TS_RO_VB_INIT, "RO vboot init" }, diff --git a/src/security/vboot/sync_ec.c b/src/security/vboot/sync_ec.c index f40934b..6c3c55a 100644 --- a/src/security/vboot/sync_ec.c +++ b/src/security/vboot/sync_ec.c @@ -55,6 +55,8 @@ vb2_error_t retval = 0; uint8_t *p;

+ timestamp_add_now(TS_START_EC_SYNC); + /* Init workspace, VBNB, etc. */ ctx.workbuf_size = VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE; ctx.workbuf = temp_workbuf; @@ -330,6 +332,7 @@ /* Callback for when Vboot is finished */ vb2_error_t VbExEcVbootDone(int in_recovery) { + timestamp_add_now(TS_END_EC_SYNC); return VB2_SUCCESS; }

Attachments:

attachment.htm (text/html — 4.5 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

21 Oct 21 Oct

1:49 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#2).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

25 Oct 25 Oct

2:07 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#3).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

2:15 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#4).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

3 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#5).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

28 Oct 28 Oct

9:27 a.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#7).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 16 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

11:09 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 29 Oct 2019 06:09:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

30 Oct 30 Oct

12:32 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#9).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 2 new timestamps to indicate the beginning and end of EC software sync.

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 16 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

2:05 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/9/src/security/vboot/ec_sync.... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/9/src/security/vboot/ec_sync.... PS9, Line 148: Might be worth to put another one here to see how long the hash took to become ready?

https://review.coreboot.org/c/coreboot/+/36209/9/src/security/vboot/ec_sync.... PS9, Line 425: ...and maybe one here so we can see how long we looped over limit power?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 30 Oct 2019 21:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

2:46 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/9/src/security/vboot/ec_sync.... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/9/src/security/vboot/ec_sync.... PS9, Line 148:

...

Might be worth to put another one here to see how long the hash took to become ready?

Sounds reasonable to me.

https://review.coreboot.org/c/coreboot/+/36209/9/src/security/vboot/ec_sync.... PS9, Line 425:

...

... […]

Also sounds reasonable to me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 30 Oct 2019 21:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

2:47 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#10).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 22 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

2:52 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#11).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 24 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

3:30 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36209/11/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/11/src/security/vboot/ec_sync... PS11, Line 444: rv = VB2_SUCCESS; nit: unnecessary (is already initialized to that)

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 30 Oct 2019 22:30:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

3:39 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#13).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 21 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

31 Oct 31 Oct

9:42 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... PS13, Line 159: timestamp_add_now(TS_EC_HASH_READY); Should we add it only when we return success? That will be consistent with other error scenarios where HASH_READY timestamp is not added?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 31 Oct 2019 16:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

3:14 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... PS13, Line 159: timestamp_add_now(TS_EC_HASH_READY);

...

Should we add it only when we return success? That will be consistent with other error scenarios whe […]

I figured leave it in, even if it returns the wrong type or doesn't finish, we'll have a timestamp saying it at least went through this path. Thoughts?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 31 Oct 2019 22:14:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Julius Werner (Code Review)

5:21 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 15: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... PS13, Line 159: timestamp_add_now(TS_EC_HASH_READY);

...

I figured leave it in, even if it returns the wrong type or doesn't finish, we'll have a timestamp s […]

I don't think it matters tbh.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 00:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Joel Kitching (Code Review)

1 Nov 1 Nov

3:22 a.m.

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36209/15/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/15/src/commonlib/include/comm... PS15, Line 198: body hash Might want to specify *what* we're hashing here, now that we are adding EC hashing. Same with the name TS_DONE_HASHING.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 10:22:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

12:34 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36209/15/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/15/src/commonlib/include/comm... PS15, Line 198: body hash

...

Might want to specify *what* we're hashing here, now that we are adding EC hashing. […]

That's fair. Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 19:34:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Joel Kitching kitching@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:13 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#16).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c M src/security/vboot/vboot_logic.c 3 files changed, 24 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 16 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

4 Nov 4 Nov

1:40 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 17: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Nov 2019 21:40:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5 Nov 5 Nov

8:52 a.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#19).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c M src/security/vboot/vboot_logic.c 3 files changed, 24 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/19

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Joel Kitching (Code Review)

7 Nov 7 Nov

6:05 a.m.

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 74: TS_START_HASH_BODY = 507, : TS_DONE_LOADING = 508, : TS_DONE_HASHING_FW_MAIN = 509, Now I'm a little confused here -- is BODY the same as FW_MAIN? Or are these distinct things?

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 211: W w

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 07 Nov 2019 14:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

8:23 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 74: TS_START_HASH_BODY = 507, : TS_DONE_LOADING = 508, : TS_DONE_HASHING_FW_MAIN = 509,

...

Now I'm a little confused here -- is BODY the same as FW_MAIN? Or are these distinct things?

Same thing as far as I understand it. I'll change START too.

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 211: W

...

w

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 07 Nov 2019 16:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Joel Kitching kitching@google.com Gerrit-MessageType: comment

Julius Werner (Code Review)

5:13 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 19:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 75: TS_DONE_LOADING = 508, nit: If you clarify DONE_HASHING, you should clarify this one too (this is loading the firmware body)

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 74: TS_START_HASH_BODY = 507, : TS_DONE_LOADING = 508, : TS_DONE_HASHING_FW_MAIN = 509,

...

Same thing as far as I understand it. I'll change START too.

Yes, but I liked "BODY" better as the terminology here tbh.

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 199: { TS_END_HASH_BODY, "finished verifying body signature (RSA)" }, All these timestamps talk about "body" either change them all or none of them (I don't see why it needs changing). Note that all the vboot timestamps will normally be together so I think it should be clear enough what is meant with body hash here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 08 Nov 2019 01:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Joel Kitching kitching@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:34 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 74: TS_START_HASH_BODY = 507, : TS_DONE_LOADING = 508, : TS_DONE_HASHING_FW_MAIN = 509,

...

Yes, but I liked "BODY" better as the terminology here tbh.

Done

https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 199: { TS_END_HASH_BODY, "finished verifying body signature (RSA)" },

...

All these timestamps talk about "body" either change them all or none of them (I don't see why it ne […]

It's all the same to me, I'll change it back.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 08 Nov 2019 03:34:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Joel Kitching kitching@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

15 Nov 15 Nov

1:46 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#20).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 21 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 20 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

5:42 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 20: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/20/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/20/src/commonlib/include/comm... PS20, Line 86: TS_EC_HASH_READY = 554, nit: I think there's an intentional split between vboot stuff and non-vboot stuff here, so maybe insert these at 515 instead?

https://review.coreboot.org/c/coreboot/+/36209/20/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/20/src/security/vboot/ec_sync... PS20, Line 473: timestamp_add_now(TS_END_EC_SYNC); nit: Is there a reason this is here and not at the end of vboot_sync_ec()? That would seem a bit more natural to me...

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 20 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 16 Nov 2019 01:42:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

16 Nov 16 Nov

11:56 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 20:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/20/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/20/src/commonlib/include/comm... PS20, Line 86: TS_EC_HASH_READY = 554,

...

nit: I think there's an intentional split between vboot stuff and non-vboot stuff here, so maybe ins […]

Fair enough.

https://review.coreboot.org/c/coreboot/+/36209/20/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/20/src/security/vboot/ec_sync... PS20, Line 473: timestamp_add_now(TS_END_EC_SYNC);

...

nit: Is there a reason this is here and not at the end of vboot_sync_ec()? That would seem a bit mor […]

Now that you say something it does look kinda weird. Will move.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 20 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 16 Nov 2019 19:56:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

12:01 p.m.

Hello Aaron Durbin, Karthik Ramasubramanian, Julius Werner, Duncan Laurie, Shelley Chen, build bot (Jenkins), Joel Kitching, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36209

to look at the new patch set (#21).

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 22 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36209/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 21 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

18 Nov 18 Nov

3:53 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

Patch Set 22: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 22 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 18 Nov 2019 23:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Nov 20 Nov

5:30 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps ......................................................................

security/vboot/sync_ec: Add timestamps

Add 4 new timestamps to the EC software sync flow: 1) Beginning of EC software sync 2) EC finished calculating Vboot hash 3) EC is no longer requesting power limiting 4) End of EC software sync

BUG=none BRANCH=none TEST=verified timestamps show up in cbmem log

Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36209 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/security/vboot/ec_sync.c 2 files changed, 22 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h index 7b1a730..d7d636e 100644 --- a/src/commonlib/include/commonlib/timestamp_serialized.h +++ b/src/commonlib/include/commonlib/timestamp_serialized.h @@ -79,6 +79,10 @@ TS_END_TPMPCR = 512, TS_START_TPMLOCK = 513, TS_END_TPMLOCK = 514, + TS_START_EC_SYNC = 515, + TS_EC_HASH_READY = 516, + TS_EC_POWER_LIMIT_WAIT = 517, + TS_END_EC_SYNC = 518, TS_START_COPYVPD = 550, TS_END_COPYVPD_RO = 551, TS_END_COPYVPD_RW = 552, @@ -202,6 +206,11 @@ { TS_END_COPYVPD_RO, "finished loading Chrome OS VPD (RO)" }, { TS_END_COPYVPD_RW, "finished loading Chrome OS VPD (RW)" },

+ { TS_START_EC_SYNC, "starting EC software sync" }, + { TS_EC_HASH_READY, "EC vboot hash ready" }, + { TS_EC_POWER_LIMIT_WAIT, "waiting for EC to allow higher power draw" }, + { TS_END_EC_SYNC, "finished EC software sync" }, + { TS_DC_START, "depthcharge start" }, { TS_RO_PARAMS_INIT, "RO parameter init" }, { TS_RO_VB_INIT, "RO vboot init" }, diff --git a/src/security/vboot/ec_sync.c b/src/security/vboot/ec_sync.c index ec048aa..c2a6b25 100644 --- a/src/security/vboot/ec_sync.c +++ b/src/security/vboot/ec_sync.c @@ -20,6 +20,7 @@ #include <security/vboot/vbnv.h> #include <security/vboot/vboot_common.h> #include <timer.h> +#include <timestamp.h> #include <vb2_api.h>

#define _EC_FILENAME(select, suffix) \ @@ -51,6 +52,8 @@ vb2_error_t retval = VB2_SUCCESS; struct vb2_context *ctx;

+ timestamp_add_now(TS_START_EC_SYNC); + ctx = vboot_get_context(); ctx->flags |= VB2_CONTEXT_EC_SYNC_SUPPORTED;

@@ -61,6 +64,8 @@ printk(BIOS_ERR, "EC software sync failed (%#x), rebooting\n", retval); vboot_reboot(); } + + timestamp_add_now(TS_END_EC_SYNC); }

/* Convert firmware image type into a flash offset */ @@ -138,6 +143,8 @@ } while (resp.status == EC_VBOOT_HASH_STATUS_BUSY && !stopwatch_expired(&sw));

+ timestamp_add_now(TS_EC_HASH_READY); + if (resp.status != EC_VBOOT_HASH_STATUS_DONE) { printk(BIOS_ERR, "%s: Hash status not done: %d\n", __func__, resp.status); @@ -415,7 +422,6 @@ int limit_power = 0; bool message_printed = false; struct stopwatch sw; - vb2_error_t rv = VB2_SUCCESS; int in_recovery = !!(ctx->flags & VB2_CONTEXT_RECOVERY_MODE);

/* @@ -425,15 +431,16 @@ if (in_recovery) return VB2_SUCCESS;

+ timestamp_add_now(TS_EC_POWER_LIMIT_WAIT); + stopwatch_init_msecs_expire(&sw, LIMIT_POWER_WAIT_TIMEOUT_MS);

- /* Ensure we have enough power to continue booting */ + /* Ensure we have enough power to continue booting. */ while (1) { if (google_chromeec_read_limit_power_request(&limit_power)) { printk(BIOS_ERR, "Failed to check EC limit power" "flag.\n"); - rv = VB2_ERROR_UNKNOWN; - break; + return VB2_ERROR_UNKNOWN; }

if (!limit_power || stopwatch_expired(&sw)) @@ -451,13 +458,13 @@ if (limit_power) { printk(BIOS_INFO, "EC requests limited power usage. Request shutdown.\n"); - rv = VBERROR_SHUTDOWN_REQUESTED; + return VBERROR_SHUTDOWN_REQUESTED; } else { printk(BIOS_INFO, "Waited %luus to clear limit power flag.\n", stopwatch_duration_usecs(&sw)); }

- return rv; + return VB2_SUCCESS; }

-- To view, visit https://review.coreboot.org/c/coreboot/+/36209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8 Gerrit-Change-Number: 36209 Gerrit-PatchSet: 27 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1825

days inactive

1855

days old

coreboot-gerrit@coreboot.org

31 comments

6 participants

tags (0)

participants (6)

Furquan Shaikh (Code Review)
Joel Kitching (Code Review)
Julius Werner (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)