Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84164?usp=email )
Change subject: tree: Use boolean for disable_package_c_state_demotion ......................................................................
tree: Use boolean for disable_package_c_state_demotion
Change-Id: I80ad02ca016ad2c8d0bfeb33e8309002dfe723c0 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/84164 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb M src/mainboard/google/brya/variants/orisa/overridetree.cb M src/mainboard/google/brya/variants/trulo/overridetree.cb M src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb M src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb M src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb M src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb M src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb M src/mainboard/system76/rpl/devicetree.cb 13 files changed, 13 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb index fcfb28c..f0370ed 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb +++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb @@ -19,7 +19,7 @@
# Disable package C state demotion on Raptorlake as a W/A for S0ix issues # seen on J0 and Q0 SKUs - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Disable C1 state auto-demotion for all brox baseboards register "disable_c1_state_auto_demotion" = "true" diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index 12dd0a1..b7b22d9 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -16,7 +16,7 @@
# Disable package C state demotion on Raptorlake as a W/A for S0ix issues # seen on J0 and Q0 SKUs - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# DPTF enable register "dptf_enable" = "1" diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb index 3d28ed3..bd5cd8b 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb @@ -92,7 +92,7 @@
# FIXME: To be enabled in future based on PNP impact data. # Disable Package C-state demotion for nissa baseboard. - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Intel Common SoC Config #+-------------------+---------------------------+ diff --git a/src/mainboard/google/brya/variants/orisa/overridetree.cb b/src/mainboard/google/brya/variants/orisa/overridetree.cb index ad5b943..99f754b 100644 --- a/src/mainboard/google/brya/variants/orisa/overridetree.cb +++ b/src/mainboard/google/brya/variants/orisa/overridetree.cb @@ -142,7 +142,7 @@
# FIXME: To be enabled in future based on PNP impact data. # Disable Package C-state demotion for nissa baseboard. - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Intel Common SoC Config #+-------------------+---------------------------+ diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb index 868342b..c5d6368 100644 --- a/src/mainboard/google/brya/variants/trulo/overridetree.cb +++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb @@ -142,7 +142,7 @@
# FIXME: To be enabled in future based on PNP impact data. # Disable Package C-state demotion for nissa baseboard. - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Intel Common SoC Config #+-------------------+---------------------------+ diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb index c303960..bdebde5 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb @@ -37,7 +37,7 @@ register "disable_c1_state_auto_demotion" = "true"
# Disable PKGC-state demotion - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Enable Energy Reporting register "pch_pm_energy_report_enable" = "1" diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb index 0a5b730..2523fb9 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb +++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb @@ -37,7 +37,7 @@ register "disable_c1_state_auto_demotion" = "true"
# Disable PKGC-state demotion - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Enable Energy Reporting register "pch_pm_energy_report_enable" = "1" diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb index facd2a5..55de7d2 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb @@ -37,7 +37,7 @@ register "disable_c1_state_auto_demotion" = "true"
# Disable PKGC-state demotion - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Enable Energy Reporting register "pch_pm_energy_report_enable" = "1" diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb index 47d27ec..4aba20b 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb @@ -37,7 +37,7 @@ register "disable_c1_state_auto_demotion" = "true"
# Disable PKGC-state demotion - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Enable Energy Reporting register "pch_pm_energy_report_enable" = "1" diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb index 73012d1..8747164 100644 --- a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb +++ b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb @@ -1,7 +1,7 @@ chip soc/intel/alderlake # Disable package C state demotion on Raptorlake as a W/A for S0ix issues # seen on J0 and Q0 SKUs - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
device domain 0 on end end diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb index 8bc35c0..0c62e4c 100644 --- a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb +++ b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb @@ -1,7 +1,7 @@ chip soc/intel/alderlake # Disable package C state demotion on Raptorlake as a W/A for S0ix issues # seen on J0 and Q0 SKUs - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
device domain 0 on device ref pch_espi on diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb index 8223418..9ba7118 100644 --- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb @@ -56,7 +56,7 @@ register "disable_c1_state_auto_demotion" = "true"
# Disable PKGC-state demotion - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
# Enable energy reporting register "pch_pm_energy_report_enable" = "1" diff --git a/src/mainboard/system76/rpl/devicetree.cb b/src/mainboard/system76/rpl/devicetree.cb index dd4d597..5acf4bb 100644 --- a/src/mainboard/system76/rpl/devicetree.cb +++ b/src/mainboard/system76/rpl/devicetree.cb @@ -21,7 +21,7 @@
# Disable package C state demotion on Raptorlake as a W/A for S0ix issues # seen on J0 and Q0 SKUs - register "disable_package_c_state_demotion" = "1" + register "disable_package_c_state_demotion" = "true"
device domain 0 on device ref system_agent on end
-
Elyes Haouas (Code Review)