Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: gma baytrail: Add connectors support ......................................................................
Patch Set 52:
(10 comments)
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-connectors.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 61: when others => 0); -- FIXME: CHV only, and on a different register!
The comment applies to DIGI_D, I guess? […]
Done, although `Digital_Port` still includes DIGI_A and DIGI_E
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 108: Panel.Off (Port_Cfg.Panel);
What do you mean? Disable VGA early?
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 134: end loop;
Again, VGA probably here already.
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-soc-dp.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 38: DP_CTL_PORT_REVERSAL : constant := 1 * 2 ** 15;
Reserved MBZ.
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 45: DP_CTL_PORT_DETECT : constant := 1 * 2 ** 2;
Please sort by offset.
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 48: DP_CTL_COLOR_RANGE_16_235 : constant := 1 * 2 ** 8;
Different meaning for VLV, and probably something to drop everywhere.
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 49: DP_CTL_SCRAMBLE_DISABLE : constant := 1 * 2 ** 7;
reserved...
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-soc-hdmi.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 26: -- VLV_PORT_PIPE_SELECT (Pipe) : c.f. hw-gfx-gma-gmch.ads
drop?
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 31: VLV_HDMI_VSYNC_NULL_INFOFRAME : constant := 1 * 2 ** 9; -- Needs to be enabled for HDMI
Will drop the comment
Done
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 38: VLV_HDMI_MASK : constant Word32 := 16#ffff_ffff#;
Good point.
Done
-
Angel Pons (Code Review)