Attention is currently required from: Raul Rangel, Jon Murphy, Paul Menzel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62165 )
Change subject: mb/google/skyrim: Configure WLAN ......................................................................
Patch Set 29:
(4 comments)
File src/mainboard/google/skyrim/romstage.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/24a8a052_32ed9128 PS29, Line 12: variant_pcie_gpio_table(&base_gpios, &base_num_gpios); You are getting the GPIO table, but not programming them.
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62165/comment/85aa9b1f_89e74283 PS29, Line 52: "GEVENT_14" Skyrim is using GPIO2/GEVENT8 for Wake on WLAN.
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/9844683a_0767d1e6 PS29, Line 167: WLAN_AUX_RESET (ACTIVE LOW) Nit: WLAN_AUX_RESET_L. Same for line 177
https://review.coreboot.org/c/coreboot/+/62165/comment/175118be_5ce2ecae PS29, Line 169: & WWAN Nit: Add WWAN when you are introducing those GPIOs as well.
-
Karthik Ramasubramanian (Code Review)