Change in coreboot[master]: cpu/x86/lapic: Fix choice X2APIC_ONLY - coreboot-gerrit

4 Jan 2022


      Attention is currently required from: Nico Huber, Wonkyu Kim, Kyösti Mälkki.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60213 )
Change subject: cpu/x86/lapic: Fix choice X2APIC_ONLY
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60213/comment/2139c5c6_8cfb45df 
PS2, Line 11: avoid entering a printk() and acquiring console_lock and
            : dead-locking.
...
With X2APIC it is WRMSR and Angel had some Haswell notes (errata) about lack of serialization.
ugh what a PITA.... maybe using cpuid explicitly as a serializing instruction would be more clear ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78070ae91e78c11c3e3aa225e5673d4667d6f7bb
Gerrit-Change-Number: 60213
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 04 Jan 2022 15:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment