Attention is currently required from: Hung-Te Lin, Knox Chiou, Yang Wu, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/62c06539_6cf7cf22?usp... :
PS2, Line 132: BOARD_GOOGLE_STEELIX
Yes,that is.
Are there Voltorb and Squirtle still being manufactured in the factory? If not, I'd like to change their unprovisioned SKU ID to 0xfffffffe, so that this ID could be shared for all mt8186t devices.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Knox Chiou
knoxchiou@google.com
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Sat, 14 Sep 2024 03:35:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com