Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 36:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... PS34, Line 14: # select MAINBOARD_HAS_LIBGFXINIT
if libgfxinit doesn't support CML, then this should be dropped
Done
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... PS34, Line 18: ONBOARD_VGA_IS_PRIMARY
is this needed?
Done
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... PS34, Line 8: ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads
if libgfxinit doesn't support CML, then this should be dropped
Done
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/40581/34/src/mainboard/clevo/cml-u/... PS34, Line 1: -- SPDX-License-Identifier: GPL-2.0-or-later
if libgfxinit doesn't support CML, then this should be dropped. […]
Done