Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 )
Change subject: src/cpu/intel: Set get_ia32_fsb function common ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c@23 PS2, Line 23: int static const short
https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c@54 PS2, Line 54: 0x4 Do you want to add names here too ?
https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h File src/include/cpu/intel/fsb.h:
https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h@17 PS2, Line 17: get_ia32_fsb(void) Add description. What is returned on error? What unit does the returned value have
-
Patrick Rudolph (Code Review)