Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42361 )
Change subject: ACPI: Replace uses of CBMEM_ID_ACPI_GNVS
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42361/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42361/5//COMMIT_MSG@9
PS5, Line 9: These are the simple cbmem_find() cases.
Maybe mention this as well: […]
Done
https://review.coreboot.org/c/coreboot/+/42361/2/src/acpi/gnvs.c
File src/acpi/gnvs.c:
PS2:
I find the mixed usage of `gnvs` and `!gnvs` in conditions rather confusing. […]
Done
https://review.coreboot.org/c/coreboot/+/42361/3/src/include/cbmem.h
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/42361/3/src/include/cbmem.h@11
PS3, Line 11: /* FIXME: Lots of includes to fix. */
: void *acpi_get_gnvs(void);
Probably there yes, and do not resolve this comment until fixed. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42361
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78e5445eb09c322ff94fe4f65345eb2997bd10ef
Gerrit-Change-Number: 42361
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 14:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment