Change in coreboot[master]: [WIP] drivers/intel/fsp2_0: Add FSP 2.3 support - coreboot-gerrit

8 Dec 2021


      Attention is currently required from: Subrata Banik, Paul Menzel, Andrey Petrov, Patrick Rudolph.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59324 )
Change subject: [WIP] drivers/intel/fsp2_0: Add FSP 2.3 support
......................................................................
Patch Set 14:
(1 comment)
File src/drivers/intel/fsp2_0/header_display.c:
https://review.coreboot.org/c/coreboot/+/59324/comment/96997ca2_1b2ff71d 
PS3, Line 10: ext_revision.val = 0;
...
its local variable so you don't need the assignment  […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59324
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1
Gerrit-Change-Number: 59324
Gerrit-PatchSet: 14
Gerrit-Owner: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bora Guvendik bora.guvendik@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Selma Bensaid selma.bensaid@intel.com
Gerrit-CC: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-CC: Subrata Banik subi.banik@gmail.com
Gerrit-CC: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 08 Dec 2021 22:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subi.banik@gmail.com
Comment-In-Reply-To: Anil Kumar K anil.kumar.k@intel.com
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment