Attention is currently required from: Nicholas Chin.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80577?usp=email )
Change subject: include/device/azalia.h: Add enum for misc field ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think it would be better to just drop this file. It serves the same purpose as azalia_device. […]
100% agree with the dropping part.
Personally, I think we should add some sort of namespace (prefix) to the enums though. This should avoid any redeclaration issues, especially since we use very generic names like `RED`, `INTERNAL`, `NC` etc (though I understand these enums are pretty much only used in `hda_verb.c`).
This also makes the enum names much more unique on a global scale and can make certain operations much more safer. For example, if you wanted to change the enum `RED` to `COLOR_RED` you simply cannot do a `sed -i 's/RED/COLOR_RED/'` on the codebase as that would probably do a lot of collateral damage. However, if it was named `AZALIA_RED` and you wanted to change this to `AZALIA_COLOR_RED` I assume this would be much more easier to do.
I do like the names of `azalia.h` for the most part, though I don't mind cutting down to `AZALIA_PINCFG_` or just `AZALIA_`.
It does make things look more "ugly" or "verbose" though. 😄