[M] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver

[Hope Wang (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.

Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
......................................................................

Patch Set 17:

(4 comments)

File src/soc/mediatek/common/mt6363_sdmadc.c:

https://review.coreboot.org/c/coreboot/+/85128/comment/4ba625bf_4c70eaa1?usp... :
PS4, Line 61: static struct pmif *pmif_arb = NULL;
            : 
            : static u32 mt6363_auxadc_read_value(u32 reg)
            : {
            : 	u32 data;
            : 
            : 	assert(pmif_arb);
            : 	pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &data);
            : 	return data;
            : }
            : 
            : static void mt6363_auxadc_write_value(u32 reg, u8 reg_val)
            : {
            : 	assert(pmif_arb);
            : 	pmif_arb->write(pmif_arb, SPMI_SLAVE_4, reg, reg_val);
            : }
            : 
            : static u32 mt6363_auxadc_read_value16(u32 reg)
            : {
            : 	u16 rdata = 0;
            : 
            : 	assert(pmif_arb);
            : 	pmif_arb->read16(pmif_arb, SPMI_SLAVE_4, reg, &rdata);
            : 	return rdata;
            : }
> If you remove `mt6363_sdmadc_init` from this file, then these functions must be moved to mt6363. […]

Done

File src/soc/mediatek/common/mt6363_sdmadc.c:

https://review.coreboot.org/c/coreboot/+/85128/comment/fd78816d_709c794c?usp... :
PS14, Line 46:
> remove

Done

https://review.coreboot.org/c/coreboot/+/85128/comment/a40d006f_e9c5df25?usp... :
PS14, Line 52: 	SDMADC_CHAN_SPEC(1),
> `[AUXADC_CHAN_VIN1] = SDMADC_CHAN_SPEC(1),`

Done

https://review.coreboot.org/c/coreboot/+/85128/comment/9e0fdc67_483523d1?usp... :
PS14, Line 60:
>

Done