Attention is currently required from: Frank Wu, Furquan Shaikh, Alan Lee, Martin Roth, Angel Pons, Ivy Jian, EricR Lai.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49783 )
Change subject: drivers/generic/bayhub_lv2: Add driver for BayHub lv2
......................................................................
Patch Set 6:
(3 comments)
File src/drivers/generic/bayhub_lv2/chip.h:
https://review.coreboot.org/c/coreboot/+/49783/comment/1dfa53d1_66b5e804
PS5, Line 3: #include <acpi/acpi_device.h>
I don't think this is required.
Done
https://review.coreboot.org/c/coreboot/+/49783/comment/2ea42bda_c08cdc7a
PS5, Line 6: /*
: * Bayhub LV2 PCI to SD bridge
: */
Use /* */ or // for short comments: https://doc.coreboot.org/coding_style. […]
Done
File src/drivers/generic/bayhub_lv2/lv2.h:
https://review.coreboot.org/c/coreboot/+/49783/comment/7be20d46_cb5960d8
PS5, Line 29:
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc1340b1a6fe7063d16c8ea16488d6e2b8b308cc
Gerrit-Change-Number: 49783
Gerrit-PatchSet: 6
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 07:47:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment