Change in coreboot[master]: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750 - coreboot-gerrit

19 Nov 2021


      Attention is currently required from: Ben Chuang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59429 )
Change subject: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750
......................................................................
Patch Set 1:
(2 comments)
File src/drivers/genesyslogic/gl9750/gl9750.c:
https://review.coreboot.org/c/coreboot/+/59429/comment/12b67356_7ff07c7b 
PS1, Line 22: 	/* Disable ASPM L0s support */
Please add a comment, why this needs to be disabled.
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/59429/comment/b344f066_8d666245 
PS1, Line 2069: #define PCI_DEVICE_ID_GLI_9750		0x9750
Please sort the list.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d60cef41baade7457a159d3ce2f8d2e6b66e71c
Gerrit-Change-Number: 59429
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Chuang benchuanggli@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Greg Tu greg.tu@genesyslogic.com.tw
Gerrit-CC: HsuanYang Chen ynop77@gmail.com
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Ben Chuang benchuanggli@gmail.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 18:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment