Attention is currently required from: Ruihai Zhou.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/ca329b31_9feb2532
PS9, Line 143: else /* BOARD_GOOGLE_KRABBY_COMMON */
The static assertion above is actually for this. If there is no bridge needed for starmie, please change this to `else if (CONFIG(BOARD_GOOGLE_KRABBY_COMMON))`, and then we can remove the static assertion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 9
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 14:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment