Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Paul Menzel.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80353?usp=email )
Change subject: mb/amd/birman_plus: Add Birman+ board support for Phoenix SOC
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/80353/comment/699aee41_7bd82518 :
PS14, Line 25: config FMDFILE
i think we're missing this line to make the build successful: […]
thanks, I was wondering why the build is failing. I have uploaded the change in latest patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80353?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Gerrit-Change-Number: 80353
Gerrit-PatchSet: 15
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 20 Feb 2024 15:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment