Attention is currently required from: Eric Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63773 )
Change subject: mb/prodrive/atlas: Fix build error
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63773/comment/103700ce_1b7219d9
PS3, Line 7: mb/prodrive/atlas: Fix build error
Yes, that's as per our guidelines. https://doc.coreboot.org/contributing/gerrit_guidelines.html
A change can go in without the wait period if its purpose is to fix a recently-introduced issue (build, boot or OS-level compatibility, not necessarily identified by coreboot.org facilities). Its commit message has to explain what change introduced the problem and the nature of the problem so that the emergency need becomes apparent. The change itself should be as limited in scope and impact as possible to make it simple to assess the impact. Such a change can be merged early with 3 Code-Review+2. For emergency fixes that affect a single project (SoC, mainboard, …) it’s strongly recommended to get a review by somebody not involved with that project to ensure that the documentation of the issue is clear enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff7e20ac271eb5b2afc9061819e2cc0cf2264cbf
Gerrit-Change-Number: 63773
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 22 Apr 2022 09:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment