Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Paul Menzel, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 38:
(23 comments)
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/9f3e0635_c5a218c5 PS38, Line 13: using Parameters = QMap < QString,QString >; space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/75788106_aa8532d4 PS38, Line 13: using Parameters = QMap < QString,QString >; spaces required around that '>' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/c6cb2414_8108c84b PS38, Line 16: bool toFile(const QString & curr_path, const Parameters & params); function definition argument 'const Parameters' should also have an identifier name
File util/coreboot-configurator/src/application/nvramtoolcli.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/72dc2881_c3ede9b9 PS38, Line 19: bool writeParameters(const Configuration::Parameters & parameters, function definition argument 'Parameters' should also have an identifier name
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/03108f77_457eb8b9 PS38, Line 20: static Node encode(const QString & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/adcf54b1_d9831271 PS38, Line 25: static bool decode(const Node & node, QString & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/a50e1948_3ade44ef PS38, Line 38: static Node encode(const QMap < Key,Value > &rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/43f59acf_e7d63373 PS38, Line 38: static Node encode(const QMap < Key,Value > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/71246b8e_454f7cad PS38, Line 49: static bool decode(const Node & node, QMap < Key, Value > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/82c3f2b5_773d8981 PS38, Line 68: static Node encode(const QVector < T > & rhs) space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/bb69ebb9_6ff663b8 PS38, Line 68: static Node encode(const QVector < T > & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/977998f5_13fbf924 PS38, Line 77: static bool decode(const Node & node, QVector < T > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/e69d98d6_51d4b006 PS38, Line 96: static Node encode(const QList < T > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/5706fa2a_adbca75b PS38, Line 99: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/4155bb7b_3c95f6cf PS38, Line 105: static bool decode(const Node & node, QList < T > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/22348d1e_726858e7 PS38, Line 124: static Node encode(const QPair < T, U > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/1af6cb88_0bfb2213 PS38, Line 133: static bool decode(const Node & node, QPair < T, U > &rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/7ff5bba3_1b1bec1e PS38, Line 150: static Node encode(const QStringList & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/07345312_1a30e2b9 PS38, Line 153: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/d74387e3_261f403c PS38, Line 153: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/73389c07_5c772b47 PS38, Line 153: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/f4d08991_c899997e PS38, Line 159: static bool decode(const Node & node, QStringList & rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/9bb8d33c_ad9fd1c7 PS38, Line 166: while (it != node.end()) that open brace { should be on the previous line
-
build bot (Jenkins) (Code Review)