HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45735 )
Change subject: sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax ......................................................................
sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax
Change-Id: I198f8df954f423ca5e19a7ee740ab062108ad14b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/i82801ix/acpi/ich9.asl M src/southbridge/intel/i82801ix/acpi/lpc.asl M src/southbridge/intel/i82801ix/acpi/usb.asl 3 files changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/45735/1
diff --git a/src/southbridge/intel/i82801ix/acpi/ich9.asl b/src/southbridge/intel/i82801ix/acpi/ich9.asl index 25a756e..11595d2 100644 --- a/src/southbridge/intel/i82801ix/acpi/ich9.asl +++ b/src/southbridge/intel/i82801ix/acpi/ich9.asl @@ -174,7 +174,7 @@ Method (_OSC, 4) { /* Check for proper GUID */ - If (LEqual (Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) + If (Arg0 == ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")) { /* Let OS control everything */ Return (Arg3) @@ -183,7 +183,7 @@ { /* Unrecognized UUID */ CreateDWordField (Arg3, 0, CDW1) - Or (CDW1, 4, CDW1) + CDW1|= 4 Return (Arg3) } } diff --git a/src/southbridge/intel/i82801ix/acpi/lpc.asl b/src/southbridge/intel/i82801ix/acpi/lpc.asl index b93fa96..1f9e701 100644 --- a/src/southbridge/intel/i82801ix/acpi/lpc.asl +++ b/src/southbridge/intel/i82801ix/acpi/lpc.asl @@ -73,7 +73,7 @@ If (HPTE) { // Note: Ancient versions of Windows don't want // to see the HPET in order to work right - If (LGreaterEqual(OSYS, 2001)) { + If (OSYS >= 2001) { Return (0xf) // Enable and show device } Else { Return (0xb) // Enable and don't show device @@ -87,16 +87,16 @@ { If (HPTE) { CreateDWordField(BUF0, _SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) - If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + If (HPAS == 1) { + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 }
- If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + If (HPAS == 2) { + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 }
- If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + If (HPAS == 3) { + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } }
diff --git a/src/southbridge/intel/i82801ix/acpi/usb.asl b/src/southbridge/intel/i82801ix/acpi/usb.asl index 55929af..f55ed66 100644 --- a/src/southbridge/intel/i82801ix/acpi/usb.asl +++ b/src/southbridge/intel/i82801ix/acpi/usb.asl @@ -21,9 +21,9 @@ { // USB Controller can wake OS from Sleep State If (Arg0) { - Store (3, U1WE) + U1WE = 3 } Else { - Store (0, U1WE) + U1WE = 0 } }
@@ -60,9 +60,9 @@ { // USB Controller can wake OS from Sleep State If (Arg0) { - Store (3, U2WE) + U2WE = 3 } Else { - Store (0, U2WE) + U2WE = 0 } }
@@ -100,9 +100,9 @@ { // USB Controller can wake OS from Sleep State If (Arg0) { - Store (3, U3WE) + U3WE = 3 } Else { - Store (0, U3WE) + U3WE = 0 } }
@@ -175,9 +175,9 @@ { // USB Controller can wake OS from Sleep State If (Arg0) { - Store (3, U1WE) + U1WE = 3 } Else { - Store (0, U1WE) + U1WE = 0 } }
@@ -214,9 +214,9 @@ { // USB Controller can wake OS from Sleep State If (Arg0) { - Store (3, U2WE) + U2WE = 3 } Else { - Store (0, U2WE) + U2WE = 0 } }
@@ -254,9 +254,9 @@ { // USB Controller can wake OS from Sleep State If (Arg0) { - Store (3, U3WE) + U3WE = 3 } Else { - Store (0, U3WE) + U3WE = 0 } }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45735 )
Change subject: sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45735/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/acpi/ich9.asl:
https://review.coreboot.org/c/coreboot/+/45735/1/src/southbridge/intel/i8280... PS1, Line 186: |= missing spacing
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45735
to look at the new patch set (#2).
Change subject: sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax ......................................................................
sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax
Change-Id: I198f8df954f423ca5e19a7ee740ab062108ad14b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/i82801ix/acpi/ich9.asl M src/southbridge/intel/i82801ix/acpi/lpc.asl M src/southbridge/intel/i82801ix/acpi/usb.asl 3 files changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/45735/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45735 )
Change subject: sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/45735/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/acpi/ich9.asl:
https://review.coreboot.org/c/coreboot/+/45735/1/src/southbridge/intel/i8280... PS1, Line 186: |=
missing spacing
Done
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45735 )
Change subject: sb/intel/i82801ix/acpi: Convert to ASL 2.0 syntax ......................................................................
Abandoned
Merge Conflict
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)