Attention is currently required from: Felix Singer, Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69863 )
Change subject: util/kconfig: Fix patch to be compatible with quilt ......................................................................
Patch Set 1:
(1 comment)
File util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch:
https://review.coreboot.org/c/coreboot/+/69863/comment/ab0d2bbb_5da3cbeb PS1, Line 38: char *autoconf_name
Is this intended?
Not intentionally by any manual intervention by me; this file was just what quilt output when I got it to reformat the original patch. Based on this line as well as line 24, it seems like quilt only outputs the first 40 characters for the section heading in the range information line. It doesn't seem to affect quilt's functionality if I add the removed parts back in though. It also seems like `diff --unified --show-c-function` has that behavior as well, and I think that's what quilt uses to format it's diffs.
-
Nicholas Chin (Code Review)