Attention is currently required from: Christian Walter, Grzegorz Bernacki, Jason Nien, Martin Roth, Vadim Bendebury, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75917?usp=email )
Change subject: mb/google: Move declaration of tis_plat_irq_status to cr50.h
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/tpm/cr50.h:
https://review.coreboot.org/c/coreboot/+/75917/comment/783acfcd_7b82db52 :
PS2, Line 28: tis_plat_irq_status
I will rename the funcion, but for now I will not move the weak implementation yet. […]
Moving the declaration and moving the 2 weak implementations look like the same thing, so I think they should be done in the same patch. In fact, aren't these 2 weak functions almost identical? It should be pretty easy to merge them.
If you care about different timeouts (10ms vs 20ms), a Kconfig option (similar to `GOOGLE_TPM_IRQ_TIMEOUT_MS`) can be added. However I doubt that the weak implementations are actually used for any board, because each `GOOGLE_BOARD_*` should have its own implementation of `tis_plat_irq_status`. If that's the case, always delaying 20ms should be good enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75917?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78dc39f2c7b44232b06947d3dfe6afa52807ced8
Gerrit-Change-Number: 75917
Gerrit-PatchSet: 2
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 26 Jun 2023 08:39:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Grzegorz Bernacki
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment