Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ronak Kanabar, Tarun.
Hello Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84356?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition ......................................................................
drivers/intel/fsp2_0: Simplify FSP global reset definition
This commit simplifies the definition of the FSP global reset return status:
1. According to the FSP 2.x specification, FSP reset status are a suite of integers starting from FSP_STATUS_RESET_REQUIRED_COLD, hence we can define the FSP Global reset as a simple index.
2. Since all the platforms defining SOC_INTEL_COMMON_FSP_RESET (tigerlake, alderlake, jasperlake, meteorlake, pantherlake, elkhartlake, skylake, cannonlake and apollolake) pick a global reset value, we can default the most common (3).
FSP 2.x status code uses the UEFI EFI_STATUS type (aka. efi_return_status_t) type whose size varies with the architecture (32-bit vs 64-bit). As a result of the code simplification introduced by this commit, FSP_STATUS_GLOBAL_RESET is appropriately defined for 64-bit FSP. Therefore, functions handling this reset status such fsp_get_pch_reset_status() must use efi_return_status_t type. It waterfalls into a few extra changes due to dependencies.
BUG=b:348678529 TEST=FSP-s Global reset request is handled properly on pantherlake fatcat
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/drivers/intel/fsp2_0/Kconfig M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/common/fsp_reset.c M src/soc/intel/common/reset.h M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/meteorlake/chip.c M src/soc/intel/pantherlake/Kconfig M src/soc/intel/pantherlake/chip.c M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig 14 files changed, 21 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/84356/3