Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58697 )
Change subject: cpu/x86/smm: Retype variables
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/58697/comment/00e9ed59_bbec7766
PS2, Line 325: uintptr_t base;
code indent should use tabs where possible
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85750282ab274f52bc176a1ac151ef2f9e0dd15d
Gerrit-Change-Number: 58697
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 31 Jan 2022 00:03:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment