Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42806 )
Change subject: bootsplash: Allow bootsplash compression ......................................................................
bootsplash: Allow bootsplash compression
TEST=include BMP bootsplash and select the compression, boot Protectli FW6 with SeaBIOS and observe the bootsplash on the screen
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id9abc6f72e3f82ce60cd06376cdc4f49f0198823 --- M Makefile.inc M src/Kconfig 2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/42806/1
diff --git a/Makefile.inc b/Makefile.inc index 7f61a5e..af931f7 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1218,9 +1218,16 @@ revision-type := raw
BOOTSPLASH_SUFFIX=$(suffix $(call strip_quotes,$(CONFIG_BOOTSPLASH_FILE))) +ifeq ($(CONFIG_COMPRESS_BOOTSPLASH),) cbfs-files-$(CONFIG_BOOTSPLASH_IMAGE) += bootsplash$(BOOTSPLASH_SUFFIX) bootsplash$(BOOTSPLASH_SUFFIX)-file := $(call strip_quotes,$(CONFIG_BOOTSPLASH_FILE)) bootsplash$(BOOTSPLASH_SUFFIX)-type := bootsplash +else +cbfs-files-$(CONFIG_BOOTSPLASH_IMAGE) += bootsplash$(BOOTSPLASH_SUFFIX).lzma +bootsplash$(BOOTSPLASH_SUFFIX).lzma-file := $(call strip_quotes,$(CONFIG_BOOTSPLASH_FILE)) +bootsplash$(BOOTSPLASH_SUFFIX).lzma-compression := $(CBFS_COMPRESS_FLAG) +bootsplash$(BOOTSPLASH_SUFFIX).lzma-type := bootsplash +endif
# Ensure that no payload segment overlaps with memory regions used by ramstage # (not for x86 since it can relocate itself in that case) diff --git a/src/Kconfig b/src/Kconfig index 1b49e2b..ec3a274 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -315,6 +315,15 @@ This will only add the image to the ROM. To actually run it check options under 'Display' section.
+config COMPRESS_BOOTSPLASH + bool "Compress bootsplash image" + depends on PAYLOAD_SEABIOS + help + The bootsplash image can be compressed with LZMA. This is especially + useful when BMP bootsplash is used and occupies too much SPI flash + space. The bootsplash CBFS file name will be compressed and suffixed + with lzma extension to indicate SeaBIOS to decompress it when loaded. + config BOOTSPLASH_FILE string "Bootsplash path and filename" depends on BOOTSPLASH_IMAGE
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42806
to look at the new patch set (#2).
Change subject: bootsplash: Allow bootsplash compression ......................................................................
bootsplash: Allow bootsplash compression
TEST=include BMP bootsplash and select the compression, boot Protectli FW6 with SeaBIOS and observe the bootsplash on the screen
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id9abc6f72e3f82ce60cd06376cdc4f49f0198823 --- M Makefile.inc M src/Kconfig 2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/42806/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42806 )
Change subject: bootsplash: Allow bootsplash compression ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42806/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42806/2//COMMIT_MSG@10 PS2, Line 10: FW6 with SeaBIOS and observe the bootsplash on the screen What is the timing difference on the device?
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42806 )
Change subject: bootsplash: Allow bootsplash compression ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42806/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42806/2//COMMIT_MSG@10 PS2, Line 10: FW6 with SeaBIOS and observe the bootsplash on the screen
What is the timing difference on the device?
Hard to tell, there are no measures, but I can test it with serial debug output and measure the delta between loading bootsplash and start showing bootsplash.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42806 )
Change subject: bootsplash: Allow bootsplash compression ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42806/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42806/2//COMMIT_MSG@10 PS2, Line 10: FW6 with SeaBIOS and observe the bootsplash on the screen
Hard to tell, there are no measures, but I can test it with serial debug output and measure the delt […]
True, it’s not easy to do in SeaBIOS and it depends on on the image file properties anyway. So, just if you are interested in it, otherwise, please ignore.
You could add one data point about the saved space for the image you used though.
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42806?usp=email )
Change subject: bootsplash: Allow bootsplash compression ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42806?usp=email )
Change subject: bootsplash: Allow bootsplash compression ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: This looks still useful.
-
Martin L Roth (Code Review) -
Michał Żygowski (Code Review)
-
Paul Menzel (Code Review)