Change in coreboot[master]: arch/x86/exception: Print stack on exception

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Raul Rangel (Code Review)

29 Jun 2020 29 Jun '20

9:35 p.m.

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

arch/x86/exception: Print stack on exception

It's useful to see the stack when an exception happens so you can see the variables on the stack, and also manually recreate the back trace.

If you need to recreate the back trace, you will need to add -fno-omit-frame-pointer to the CFLAGS.

BUG=b:159081993 TEST=Caused an exception and saw the stack dumped. Then I manually recreated the back trace.

0xcc6fff6c: 0xcc6ce02e <- 0xcc6ce02e is in dev_initialize 0xcc6fff68: 0xcc6fff88 <-- frame 1 0xcc6fff64: 0x00000005 0xcc6fff60: 0x000000dc 0xcc6fff5c: 0x00000000 0xcc6fff58: 0x00000200 0xcc6fff54: 0x00000000 0xcc6fff50: 0x00000400 0xcc6fff4c: 0xcc6d72d4 <- 0xcc6d72d4 is in setup_default_ebdad 0xcc6fff48: 0xcc6fff68 <-ebp 0xcc6fff44: 0x00000005 0xcc6fff40: 0xcc6f571c <-esp

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef --- M src/arch/x86/exception.c 1 file changed, 12 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/42884/1

diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index 46ba370..3a921c0 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -517,7 +517,18 @@ printk(BIOS_EMERG, "\n%p:\t", code + i); printk(BIOS_EMERG, "%.2x ", code[i]); } - die(""); + + /* Align to 4-byte boundary and up the stack. */ + u32 *ptr = (u32 *)(((uintptr_t)info->esp & ~0x3) + MDUMP_SIZE - 4); + for (i = 0; i < MDUMP_SIZE / sizeof(u32); ++i, --ptr) { + printk(BIOS_EMERG, "\n%p:\t0x%08x", ptr, *ptr); + if ((uintptr_t)ptr == info->ebp) + printk(BIOS_EMERG, " <-ebp"); + else if ((uintptr_t)ptr == info->esp) + printk(BIOS_EMERG, " <-esp"); + } + + die("\n"); #endif }

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Aaron Durbin (Code Review)

30 Jun 30 Jun

9:56 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42884/1/src/arch/x86/exception.c File src/arch/x86/exception.c:

https://review.coreboot.org/c/coreboot/+/42884/1/src/arch/x86/exception.c@52... PS1, Line 522: (uintptr_t)info->esp & ~0x3 ALIGN_DOWN

Raul Rangel (Code Review)

8 Jul 8 Jul

5:02 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42884/1/src/arch/x86/exception.c File src/arch/x86/exception.c:

https://review.coreboot.org/c/coreboot/+/42884/1/src/arch/x86/exception.c@52... PS1, Line 522: (uintptr_t)info->esp & ~0x3

...

ALIGN_DOWN

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Gerrit-Change-Number: 42884 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 17:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Raul Rangel (Code Review)

5:02 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42884

to look at the new patch set (#2).

Change subject: arch/x86/exception: Print stack on exception ......................................................................

arch/x86/exception: Print stack on exception

It's useful to see the stack when an exception happens so you can see the variables on the stack, and also manually recreate the back trace.

If you need to recreate the back trace, you will need to add -fno-omit-frame-pointer to the CFLAGS.

BUG=b:159081993 TEST=Caused an exception and saw the stack dumped. Then I manually recreated the back trace.

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef --- M src/arch/x86/exception.c 1 file changed, 12 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/42884/2

Aaron Durbin (Code Review)

5:26 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Gerrit-Change-Number: 42884 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 17:26:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

10 Jul 10 Jul

3:39 p.m.

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

arch/x86/exception: Print stack on exception

It's useful to see the stack when an exception happens so you can see the variables on the stack, and also manually recreate the back trace.

If you need to recreate the back trace, you will need to add -fno-omit-frame-pointer to the CFLAGS.

BUG=b:159081993 TEST=Caused an exception and saw the stack dumped. Then I manually recreated the back trace.

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Reviewed-on: https://review.coreboot.org/c/coreboot/+/42884 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/exception.c 1 file changed, 12 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index 318a219..958ebfc 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -544,7 +544,18 @@ printk(BIOS_EMERG, "\n%p:\t", code + i); printk(BIOS_EMERG, "%.2x ", code[i]); } - die(""); + + /* Align to 4-byte boundary and up the stack. */ + u32 *ptr = (u32 *)(ALIGN_DOWN((uintptr_t)info->esp, sizeof(u32)) + MDUMP_SIZE - 4); + for (i = 0; i < MDUMP_SIZE / sizeof(u32); ++i, --ptr) { + printk(BIOS_EMERG, "\n%p:\t0x%08x", ptr, *ptr); + if ((uintptr_t)ptr == info->ebp) + printk(BIOS_EMERG, " <-ebp"); + else if ((uintptr_t)ptr == info->esp) + printk(BIOS_EMERG, " <-esp"); + } + + die("\n"); #endif }

-- To view, visit https://review.coreboot.org/c/coreboot/+/42884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Gerrit-Change-Number: 42884 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

Angel Pons (Code Review)

5:58 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c File src/arch/x86/exception.c:

https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c@54... PS4, Line 549: u32 I don't think this will work very well in places where pointers aren't 32-bit (x86_64)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Gerrit-Change-Number: 42884 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 17:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

6:01 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c File src/arch/x86/exception.c:

https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c@54... PS4, Line 549: u32

...

I don't think this will work very well in places where pointers aren't 32-bit (x86_64)

That's a good point. We should adjust the type to uintptr_t.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Gerrit-Change-Number: 42884 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 18:01:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Raul Rangel (Code Review)

7:08 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )

Change subject: arch/x86/exception: Print stack on exception ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c File src/arch/x86/exception.c:

https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c@54... PS4, Line 549: u32

...

That's a good point. We should adjust the type to uintptr_t.

I'll get a patch pushed up.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef Gerrit-Change-Number: 42884 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 19:08:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

1544

days inactive

1555

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Aaron Durbin (Code Review)
Angel Pons (Code Review)
Raul Rangel (Code Review)