Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42427 )
Change subject: arch/x86: Pass GNVS as parameter to SMM module
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42427/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42427/6//COMMIT_MSG@7
PS6, Line 7: Pass GNVS as parameter to SMM module
The passing is being done in a patch prior to this one. This patch is taking advantage of that work. […]
Agreed. It would be good to explain something here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d7417462830443f9c96273d2cc326cbcc3b17dd
Gerrit-Change-Number: 42427
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 21:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment