Attention is currently required from: Martin Roth, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50472 )
Change subject: elog: Support logging CSE Lite info in elog ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50472/comment/b6f7afb3_54114c04 PS5, Line 23: ... : 3 | 2021-01-17 08:01:57 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269 : | YES | 0x5 | 0x0 | RW What does the rest of the eventlog look like? I think we log things like boot count and system boot info much later in ramstage. Is this info printed before System Boot in the log?
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/50472/comment/33c09322_15c62505 PS5, Line 136: ((hfsts1.fields.spi_protection_mode == 0) && : (hfsts6.fields.fpf_soc_lock == 1)) Can you please update this to use `cse_mfg_mode` as well?
File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/c/coreboot/+/50472/comment/9461116e_bff16d54 PS5, Line 131: hfsts1.fields.mfg_mode Same here and for other SoCs.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/50472/comment/c446c1b3_021b83ab PS5, Line 14: nit: use space here and on line 15 below for consistency with other #defines in this file.
-
Furquan Shaikh (Code Review)