[XS] Change in coreboot[master]: [RFC] drivers/amd/agesa/state_machine: disable NULL breakpoint for bi... - coreboot-gerrit

14 Aug 2023


      Attention is currently required from: Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77171?usp=email )
Change subject: [RFC] drivers/amd/agesa/state_machine: disable NULL breakpoint for binaryPI
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
Maybe we introduce a new version of the breakpoint message that puts out an info level message saying that there's a null dereference in a blob instead of disabling it completely? It seems somewhat questionable to me that any of the blobs would need to access the NULL page.
Even if we do go this route, maybe we want to just disable the deref breakpoint, not the instruction breakpoint? That would require updating code in null_breakpoint.c.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/77171?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1fa6a665fadd6d1bf68f6adfc4f86725d92695e
Gerrit-Change-Number: 77171
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 14 Aug 2023 20:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment