Attention is currently required from: Shuo Liu.
Patrick Rudolph has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/81567?usp=email )
Change subject: soc/intel/xeon_sp: Add PCIe root port driver
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/xeon_sp/pcie_root_port.c:
https://review.coreboot.org/c/coreboot/+/81567/comment/048fb948_740abf5f?usp... :
PS14, Line 28: }
Is that intended that on the else path pciexp_scan_bridge() is not being called? As far as I understand the bridge wouldn't be scanned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81567?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I81bd5d5a2e62301543a332162a5a789e0793e18e
Gerrit-Change-Number: 81567
Gerrit-PatchSet: 14
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Wed, 16 Oct 2024 10:56:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No