Change in coreboot[master]: mb/google/cherry: enable display support - coreboot-gerrit

16 Jun 2021


      Attention is currently required from: Hung-Te Lin, jitao shi, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55574 )
Change subject: mb/google/cherry: enable display support
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/cherry/mainboard.c:
https://review.coreboot.org/c/coreboot/+/55574/comment/d17e3f9d_e66fa22b 
PS3, Line 187: if (!configure_display())
             : 			printk(BIOS_ERR, "%s: Failed to initialize display\n",
             : 			       __func__);
...
given there's only one 'return false' in configure_display and it's already printing the error messa […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida6c157a6a3bd904d3fa3dd2001385ced34f7711
Gerrit-Change-Number: 55574
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: jitao shi jitao.shi@mediatek.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 17 Jun 2021 02:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment