Attention is currently required from: Christian Walter, Johnny Lin, Patrick Rudolph, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80092?usp=email )
Change subject: soc/intel/xeon_sp: Find VTD devices by PCI DEV ID
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/xeon_sp/memmap.c:
https://review.coreboot.org/c/coreboot/+/80092/comment/2c794e6b_1ab872a1 :
PS1, Line 71: PCI_VID_INTEL, MMAP_VTD_STACK_CFG_REG_DEVID
Isn't the MMAP_VTD_CFG_REG_DEVID case covered by VTD_DEV(0) which the other stacks are compared against?
I guess it probably is. Aynway, the TXT error codes would be sufficiently clear.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80092?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa96
Gerrit-Change-Number: 80092
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment